<random>: Prevent full-width shifts in independent_bits_engine#5740
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom Sep 25, 2025
Merged
<random>: Prevent full-width shifts in independent_bits_engine#5740StephanTLavavej merged 3 commits intomicrosoft:mainfrom
<random>: Prevent full-width shifts in independent_bits_engine#5740StephanTLavavej merged 3 commits intomicrosoft:mainfrom
Conversation
StephanTLavavej
approved these changes
Sep 25, 2025
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing the STL's most common UB mistake! ⏪ 😻 ⏩ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5719.
The second loop in
operator()is fine because it's only executed if multiple random values are needed (modulo the rejection sampling), i.e.,_Nx > 1. In such cases,_Wx0 <= _Wx / _Nx <= sizeof(_Eres)*8 / 2, so_Wx0+1 < sizeof(_Eres)*8as long as_Eresis more than two bits.